Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 4.2.3 release #6353

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Prep for 4.2.3 release #6353

merged 2 commits into from
Aug 7, 2022

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Aug 6, 2022

Description
Updates changelog and version references for 4.2.3.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: kenjis <[email protected]>
@MGatner MGatner merged commit d77883e into develop Aug 7, 2022
@kenjis
Copy link
Member

kenjis commented Aug 7, 2022

We should have checked the warning for the docs:
https://github.com/codeigniter4/CodeIgniter4/pull/6353/files#diff-f9970d86aca13e5c6ae72e6f0a0b8aaac1f242741a364ce3a960bc3866496ccb

Check warning on line 1 in user_guide_src/source/installation/upgrade_423.rst
GitHub Actions / Check User Guide syntax
user_guide_src/source/installation/upgrade_423.rst#L1
document isn't included in any toctree

@MGatner
Copy link
Member Author

MGatner commented Aug 8, 2022

That didn't show up anywhere for me. Is there any way that can elevate to an actual error so the Action will fail? @paulbalandan might know?

@kenjis
Copy link
Member

kenjis commented Aug 8, 2022

This worked!

$ make html SPHINXOPTS="-W"
Running Sphinx v4.5.0
making output directory... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 207 source files that are out of date
updating environment: [new config] 207 added, 0 changed, 0 removed
reading sources... [100%] tutorial/static_pages                                                                                                                      
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] tutorial/static_pages                                                                                                                       

Warning, treated as error:
/Users/kenji/work/codeigniter/CodeIgniter4/user_guide_src/source/database/utilities.rst:20:Could not lex literal_block as "html+php". Highlighting skipped.
make: *** [html] Error 2

https://stackoverflow.com/questions/38048945/how-to-turn-warnings-into-errors-when-building-sphinx-documentation-with-setupto

@kenjis
Copy link
Member

kenjis commented Aug 8, 2022

I sent a PR #6359

@kenjis kenjis deleted the release-4.2.3 branch August 14, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants