Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation custom error with asterisk field #6340

Closed

Conversation

ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Aug 4, 2022

Description
Fixes #6245

  • increase judgment if user set up custom validation error with asterisk field.
  • increase testRunWithCustomErrorsAndAsteriskField for testing

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 4, 2022
@MGatner
Copy link
Member

MGatner commented Aug 5, 2022

Thanks for the submission @ping-yee! Please address Kenjis' concerns above.
Also let's get @iRedds in here to check the actual solution.

@ping-yee
Copy link
Contributor Author

ping-yee commented Aug 5, 2022

Thanks for your recommend and I will change my code to follow the contributing rules!
I will close this PR then open new one that has securely signed commits.

@iRedds
Copy link
Collaborator

iRedds commented Aug 5, 2022

@ping-yee Doesn't work if a label is specified.

@ping-yee
Copy link
Contributor Author

ping-yee commented Aug 5, 2022

@iRedds Like what data set?
Because I run the all of validation test and don't get the problem...

@iRedds
Copy link
Collaborator

iRedds commented Aug 5, 2022

['foo.*.bar' => ['label' => 'foo bar', 'rules' => 'required']],

@ping-yee
Copy link
Contributor Author

ping-yee commented Aug 5, 2022

@iRedds Ok, I got it.
I'll fix this problem when I sent the new PR with securely signed commits.

@ping-yee ping-yee closed this Aug 6, 2022
@ping-yee ping-yee deleted the fix-validation-error-field branch September 12, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Custom validation error for a field with an asterisk.
4 participants