Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random_string('crypto') may return string less than $len or ErrorException #6334

Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix: random_string('crypto') may return string less than $len or ErrorException #6334

merged 2 commits into from
Aug 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 3, 2022 •
edited
Loading

Description
Fixes #6330

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Aug 3, 2022
@kenjis kenjis force-pushed the fix-random_string-crypto branch from 8a47a7e to b55b3e7 Compare August 4, 2022 02:39
@kenjis
Copy link
Member Author

kenjis commented Aug 4, 2022

Added the docs.

@kenjis kenjis requested review from MGatner and paulbalandan August 4, 2022 06:26
@kenjis kenjis merged commit 237e5da into codeigniter4:develop Aug 4, 2022
@kenjis kenjis deleted the fix-random_string-crypto branch August 4, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: random_string() Implicit conversion from float 4.5 to int loses precision
3 participants
@kenjis @MGatner @paulbalandan