Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix types in PHPDocs in RESTful controllers #6311

Merged
merged 3 commits into from
Aug 4, 2022
Merged

docs: fix types in PHPDocs in RESTful controllers #6311

merged 3 commits into from
Aug 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 29, 2022

Description
See #6310

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

MGatner
MGatner requested changes Jul 30, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, some points for discussion.

system/RESTful/ResourceController.php Outdated Show resolved Hide resolved
system/RESTful/ResourceController.php Outdated Show resolved Hide resolved
kenjis added 3 commits August 4, 2022 17:18
@kenjis
docs: fix types in PHPDocs
7676ba2
@kenjis
docs: fix @return
a0ababf 
Controller method can return string or void.
@kenjis
docs: add int to @param $id
d6cd7b1 
There is no way to pass int value to the controller method now,
unless extending Router. But $id may be essentially int, and
we should support int.
@kenjis kenjis force-pushed the fix-type-RESTful-controllers branch from 8b6379c to d6cd7b1 Compare August 4, 2022 08:31
@kenjis kenjis requested a review from MGatner August 4, 2022 08:33
MGatner
MGatner approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kenjis kenjis merged commit c0b9928 into codeigniter4:develop Aug 4, 2022
@kenjis kenjis deleted the fix-type-RESTful-controllers branch August 4, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner