feat: spark filter:check command
#6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function run(array $params) | ||
| { | ||
| if (count($params) !== 2) { |
There was a problem hiding this comment.
I think it would be better to use ! isset($params[1]) to check if all arguments are present. If, for example, a user supplied only the first argument then, out of the blue, supplies an option (e.g. --force) then would count($params) be 2?
Comment on lines
100
to
102
| CLI::color( | ||
| '"' . strtoupper($method) . ' ' . $route . '"', | ||
| 'black' |
There was a problem hiding this comment.
How would this look on black consoles?
paulbalandan
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spark filter:checkcommand to check filters for a route.Checklist: