Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Autoloader::sanitizeFilename() throws Exception #6193

Merged
merged 5 commits into from
Jul 3, 2022
Merged

feat: Autoloader::sanitizeFilename() throws Exception #6193

merged 5 commits into from
Jul 3, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 28, 2022 •
edited
Loading

Description
Generally Sanitization is bad practice.

before:

$ php spark

PHP Fatal error: Uncaught Error: Class "Config\App" not found in /Users/kenji/tmp/software(locale)/project-root/vendor/codeigniter4/framework/system/Config/Factories.php:126

after:

$ php spark

PHP Fatal error: Uncaught InvalidArgumentException: The file path contains special character that is not allowed: "/Users/kenji/tmp/software(locale)/project-root/vendor/codeigniter4/framework/system/Autoloader/FileLocator.php" in /Users/kenji/tmp/software(locale)/project-root/vendor/codeigniter4/framework/system/Autoloader/Autoloader.php:315

Related #6192

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Jun 28, 2022
@kenjis kenjis force-pushed the fix-Autoloader-sanitizeFilename branch from 35b289a to 307e194 Compare July 1, 2022 07:48
@kenjis kenjis merged commit a393873 into codeigniter4:4.3 Jul 3, 2022
@kenjis kenjis deleted the fix-Autoloader-sanitizeFilename branch July 3, 2022 07:32
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan