feat: add method to insert empty data in Model

system/BaseModel.php

@@ -314,6 +314,11 @@ abstract class BaseModel
      */
     protected $afterDelete = [];
 
+    /**
+     * Whether to allow inserting empty data.
+     */
+    protected bool $allowEmptyInserts = false;
+
     public function __construct(?ValidationInterface $validation = null)
     {
         $this->tempReturnType     = $this->returnType;
@@ -742,7 +747,7 @@ public function insert($data = null, bool $returnID = true)
 
         // doProtectFields() can further remove elements from
         // $data so we need to check for empty dataset again
-        if (empty($data)) {
+        if (! $this->allowEmptyInserts && empty($data)) {
             throw DataException::forEmptyDataset('insert');
         }
 
@@ -1640,7 +1645,7 @@ protected function transformDataToArray($data, string $type): array
             throw new InvalidArgumentException(sprintf('Invalid type "%s" used upon transforming data to array.', $type));
         }
 
-        if (empty($data)) {
+        if (! $this->allowEmptyInserts && empty($data)) {
             throw DataException::forEmptyDataset($type);
         }
 
@@ -1659,7 +1664,7 @@ protected function transformDataToArray($data, string $type): array
         }
 
         // If it's still empty here, means $data is no change or is empty object
-        if (empty($data)) {
+        if (! $this->allowEmptyInserts && empty($data)) {
             throw DataException::forEmptyDataset($type);
         }
 
@@ -1765,4 +1770,14 @@ protected function fillPlaceholders(array $rules, array $data): array
 
         return $rules;
     }
+
+    /**
+     * Sets $allowEmptyInserts.
+     */
+    public function allowEmptyInserts(bool $value = true): self
+    {
+        $this->allowEmptyInserts = $value;
+
+        return $this;
+    }
 }

system/Model.php

@@ -275,7 +275,34 @@ protected function doInsert(array $data)
             $builder->set($key, $val, $escape[$key] ?? null);
         }
 
-        $result = $builder->insert();
+        if ($this->allowEmptyInserts && empty($data)) {
+            $table = $this->db->protectIdentifiers($this->table, true, null, false);
+            if ($this->db->getPlatform() === 'MySQLi') {
+                $sql = 'INSERT INTO ' . $table . ' VALUES ()';
+            } elseif ($this->db->getPlatform() === 'OCI8') {
+                $allFields = $this->db->protectIdentifiers(
+                    array_map(
+                        static fn ($row) => $row->name,
+                        $this->db->getFieldData($this->table)
+                    ),
+                    false,
+                    true
+                );
+
+                $sql = sprintf(
+                    'INSERT INTO %s (%s) VALUES (%s)',
+                    $table,
+                    implode(',', $allFields),
+                    substr(str_repeat(',DEFAULT', count($allFields)), 1)
+                );
+            } else {
+                $sql = 'INSERT INTO ' . $table . ' DEFAULT VALUES';
+            }
+
+            $result = $this->db->query($sql);
+        } else {
+            $result = $builder->insert();
+        }
 
         // If insertion succeeded then save the insert ID
         if ($result) {

system/Validation/FileRules.php

@@ -133,7 +133,7 @@ public function is_image(?string $blank, string $params): bool
 
             // We know that our mimes list always has the first mime
             // start with `image` even when then are multiple accepted types.
-            $type = Mimes::guessTypeFromExtension($file->getExtension());
+            $type = Mimes::guessTypeFromExtension($file->getExtension()) ?? '';
 
             if (mb_strpos($type, 'image') !== 0) {
                 return false;

tests/system/Models/InsertModelTest.php

@@ -14,6 +14,8 @@
 use CodeIgniter\Database\Exceptions\DataException;
 use CodeIgniter\Entity\Entity;
 use CodeIgniter\I18n\Time;
+use CodeIgniter\Model;
+use Config\Database;
 use stdClass;
 use Tests\Support\Entity\User;
 use Tests\Support\Models\JobModel;
@@ -202,6 +204,35 @@ public function testInsertArrayWithNoDataException(): void
         $this->createModel(UserModel::class)->insert([]);
     }
 
+    public function testInsertPermitInsertNoData(): void
+    {
+        $forge = Database::forge();
+        $forge->addField([
+            'id'         => ['type' => 'INTEGER', 'constraint' => 11, 'auto_increment' => true],
+            'created_at' => ['type' => 'INTEGER', 'constraint' => 11, 'null' => true],
+            'updated_at' => ['type' => 'INTEGER', 'constraint' => 11, 'null' => true],
+        ])->addKey('id', true)->createTable('insert_no_data', true);
+
+        $model                       = new class () extends Model {
+            protected $table         = 'insert_no_data';
+            protected $allowedFields = [
+                'updated_at',
+            ];
+        };
+
+        $model->allowEmptyInserts()->insert([]);
+
+        $this->seeInDatabase('insert_no_data', ['id' => $model->getInsertID()]);
+
+        $forge->dropTable('insert_no_data');
+
+        $this->expectException(DataException::class);
+        $this->expectExceptionMessage('There is no data to insert.');
+
+        $model->allowEmptyInserts(false);
+        $model->insert([]);
+    }
+
     public function testInsertObjectWithNoDataException(): void
     {
         $data = new stdClass();

tests/system/Validation/FileRulesTest.php

@@ -41,7 +41,9 @@ final class FileRulesTest extends CIUnitTestCase
 
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
+
         $this->validation = new Validation((object) $this->config, Services::renderer());
         $this->validation->reset();
 
@@ -229,6 +231,7 @@ public function testIsntImage(): void
             'type'     => 'application/address',
             'error'    => UPLOAD_ERR_OK,
         ];
+
         $this->validation->setRules(['avatar' => 'is_image[stuff]']);
         $this->assertFalse($this->validation->run([]));
     }

tests/system/Validation/StrictRules/FileRulesTest.php

@@ -42,7 +42,9 @@ final class FileRulesTest extends CIUnitTestCase
 
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
+
         $this->validation = new Validation((object) $this->config, Services::renderer());
         $this->validation->reset();
 
@@ -230,6 +232,7 @@ public function testIsntImage(): void
             'type'     => 'application/address',
             'error'    => UPLOAD_ERR_OK,
         ];
+
         $this->validation->setRules(['avatar' => 'is_image[stuff]']);
         $this->assertFalse($this->validation->run([]));
     }

user_guide_src/source/changelogs/v4.2.0.rst

@@ -13,6 +13,7 @@ Highlights
 **********
 
 - Update minimal PHP requirement to 7.4.
+- To make the default configuration more secure, auto-routing has been changed to disabled by default.
 - **OCI8 Driver for Oracle Database** (*contributed by* `ytetsuro <https://github.com/ytetsuro>`_). See `Database`_.
 - **Improved Auto Routing** (opt-in) (*contributed by* `kenjis <https://github.com/kenjis>`_). See `New Improved Auto Routing`_.
 - Query Builder **Subqueries** and **UNION** support (*contributed by* `Andrey Pyzhikov <https://github.com/iRedds>`_). See `Database`_.
@@ -134,11 +135,11 @@ Changes
 *******
 
 - Update minimal PHP requirement to 7.4.
-- The current version of Content Security Policy (CSP) outputs one nonce for script and one for style tags. The previous version outputted one nonce for each tag.
-- The process of sending cookies has been moved to the ``Response`` class. Now the ``Session`` class doesn't send cookies, set them to the Response.
+- To make the default configuration more secure, auto-routing has been changed to disabled by default.
 - Validation. Changed generation of errors when using fields with a wildcard (*). Now the error key contains the full path. See :ref:`validation-getting-all-errors`.
 - ``Validation::getError()`` when using a wildcard will return all found errors matching the mask as a string.
-- To make the default configuration more secure, auto-routing has been changed to disabled by default.
+- The current version of Content Security Policy (CSP) outputs one nonce for script and one for style tags. The previous version outputted one nonce for each tag.
+- The process of sending cookies has been moved to the ``Response`` class. Now the ``Session`` class doesn't send cookies, set them to the Response.
 
 Deprecations
 ************

user_guide_src/source/changelogs/v4.3.0.rst

@@ -21,6 +21,7 @@ Enhancements
 
 - Added the ``StreamFilterTrait`` to make it easier to work with capturing data from STDOUT and STDERR streams. See :ref:`testing-overview-stream-filters`.
 - Added before and after events to ``BaseModel::insertBatch()`` and ``BaseModel::updateBatch()`` methods. See :ref:`model-events-callbacks`.
+- Added ``Model::allowEmptyInserts()`` method to insert empty data. See :ref:`Using CodeIgniter's Model <model-allow-empty-inserts>`
 - Added ``$routes->useSupportedLocalesOnly(true)`` so that the Router returns 404 Not Found if the locale in the URL is not supported in ``Config\App::$supportedLocales``. See :ref:`Localization <localization-in-routes>`
 - The call handler for Spark commands from the ``CodeIgniter\CodeIgniter`` class has been extracted. This will reduce the cost of console calls.
 

user_guide_src/source/models/model.rst

@@ -310,6 +310,17 @@ the array's values are the values to save for that key:
 
 You can retrieve the last inserted row's primary key using the ``getInsertID()`` method.
 
+.. _model-allow-empty-inserts:
+
+allowEmptyInserts()
+-------------------
+
+Since v4.3.0, you can use ``allowEmptyInserts()`` method to insert empty data. The Model throws an exception when you try to insert empty data by default. But if you call this method, the check will no longer be performed.
+
+.. literalinclude:: model/056.php
+
+You can enable the check again by calling ``allowEmptyInserts(false)``.
+
 update()
 --------
 

user_guide_src/source/models/model/056.php

@@ -0,0 +1,3 @@
+<?php
+
+$userModel->allowEmptyInserts()->insert([]);