Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless catch #6095

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Remove useless catch #6095

merged 1 commit into from
Jun 8, 2022

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jun 7, 2022 •
edited by kenjis
Loading

Description
It is useless to catch the exception then rethrow it without doing anything on it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jun 8, 2022
@MGatner MGatner merged commit 1398b13 into codeigniter4:develop Jun 8, 2022
@paulbalandan paulbalandan deleted the useless-catch branch June 8, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner