Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove App\ and Config\ in autoload.psr-4 in app starter composer.json #5824

Merged
merged 2 commits into from
Mar 24, 2022
Merged

config: remove App\ and Config\ in autoload.psr-4 in app starter composer.json #5824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e0594
chore: remove App\ and Config\ in autoload.psr-4 in app starter compo…
kenjis Mar 23, 2022
135222d
docs: add @TODO
kenjis Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions admin/starter/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
"ext-fileinfo": "Improves mime type detection for files"
},
"autoload": {
"psr-4": {
"App\\": "app",
"Config\\": "app/Config"
},
"exclude-from-classmap": [
"**/Database/Migrations/**"
]
Expand Down
4 changes: 4 additions & 0 deletions system/CLI/Commands.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ public function getCommands()
/**
* Discovers all commands in the framework and within user code,
* and collects instances of them to work with.
*
* @TODO this approach (find qualified classname from path) causes error,
* when using Composer autoloader.
* See https://github.com/codeigniter4/CodeIgniter4/issues/5818
*/
public function discoverCommands()
{
Expand Down