We changed the reference of Services class.

[ytetsuro]

I tried to overwrite Router with application/Config/Services.php, but CodeIgniter.php refers to CodeIgniter\Config\Servces.
Therefore, I made this PR.

sample: application/Config/Services.php

class Services extends CoreServices
{

	public static function router(\CodeIgniter\Router\RouteCollectionInterface $routes = null, $getShared = true)
	{
		if ($getShared)
		{
			return self::getSharedInstance('router', $routes);
		}

		if (empty($routes))
		{
			$routes = self::routes(true);
		}

		return new \App\Core\Router\Router($routes);
	}
}

[lonnieezell]

Looks good. Thanks1

[ytetsuro]

Merged thanks!!

[daylightstudio]

I'm currently getting an error with a fresh download that I think is caused by this merge. The error is:

Fatal error: Cannot use Config\Services as Services because the name is already in use in .../system/CodeIgniter.php on line 38

[lonnieezell]

@daylightstudio Weird, I'm not seeing that. Did a git clone, went to the folder and ran php serve.php and fired up the browser to localhost:8080 and it all worked as expected on the welcome page.

[daylightstudio]

OK. Let me have some other folks at work test it out to see if they can replicate. I wasn't seeing anyone else complaining about the issue either so let me dig into it further and I'll report back what I'm able to find out. What version of PHP 7 are you running just for comparison even though it seems highly unlikely that's the issue? I was testing it on a basic MAMP installation with PHP 7.0.10.

[lonnieezell]

That was tested under a MAMP 7.0.15 release.

[daylightstudio]

FYI, I upgraded to the latest version of MAMP that has the 7.0.15 version and the problem went away. Not sure if it was a PHP/MAMP version or something else, but my issue has been resolved.

[lonnieezell]

Good to know! Very strange issue, though.

[davidgv88]

In WAMP I use PHP 7.0.10 and i get the same message:

Fatal error: Cannot use Config\Services as Services because the name is already in use in C:\wamp64\www\CodeIgniter4\system\CodeIgniter.php on line 38