Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate object implementations of clean_path() function #5681

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Deprecate object implementations of clean_path() function #5681

merged 2 commits into from
Feb 12, 2022

Conversation

paulbalandan
Copy link
Member

Description
Use the clean_path() function instead.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan force-pushed the deprecate-object-clean-path-methods branch from 8af5a35 to 9c3f6e9 Compare February 12, 2022 14:21
@paulbalandan
Copy link
Member Author

I've pushed another set of deprecations for Logger::cleanFilenames and TestLogger::cleanup. Apparently, these are everywhere. 😂

@paulbalandan paulbalandan changed the title Deprecate both Exceptions::cleanPath() and BaseCollector::cleanPath() Deprecate object implementations of clean_path() function Feb 12, 2022
@kenjis kenjis merged commit ccd49e4 into codeigniter4:develop Feb 12, 2022
@kenjis kenjis added the refactor Pull requests that refactor code label Feb 13, 2022
@paulbalandan paulbalandan deleted the deprecate-object-clean-path-methods branch February 13, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @lonnieezell @kenjis