-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation: support placeholders for anything #5545
Validation: support placeholders for anything #5545
Conversation
34e33d0
to
c1974ee
Compare
This method change should be safe, right? Since all extended classes will still have |
No, the parameter will no longer be contravariant since extending classes will now be typehinting a specific type (string) from the parent's type (this PR proposing as mixed). |
In that case we will we need additions to the upgrade guide noting the BC. Since we have a |
LGTM except documentation. |
75ca70c
to
ab8eadb
Compare
ab8eadb
to
84ac2ea
Compare
🥳 |
Description
Supersedes and closes #3910
Fixes #3774
I tried cherry-picking @element-code 's commit but ended up with merge conflicts instead, so the original authorship was lost.
The breaking change with this is the signature change of
setRule
.Checklist: