-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: KINT d()/trace() visual error when activating CSP #5482
Conversation
984806c
to
a039389
Compare
Can we still use other helpers like |
a039389
to
af51fbd
Compare
Yes. I confirmed But |
To define d() in system/Common.php
af51fbd
to
7af9f9f
Compare
I added fix for |
If not, trace() would consume large memory
9d8d7a1
to
8e3b375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this effect CLI output? Will Kint function modifiers like @
and +
still work?
@MGatner But with this PR, |
Have no idea. 🤔 Kint has always seemed like magic to me. I assume it is based on some Reflection trace capabilities. I don't fully understand what the issue is to begin with so I'm not sure if this trade-off is worth it. I use the Kint modifiers in some projects so this would be a breaking change for me, no clue if others are even aware of them. |
They actually parse back the source file calling the kint method: |
@sfadschm Thanks! It is too magic. |
Description
Fixes #5475
d()
trace()
Checklist: