Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Time::getDst() #5415

Merged
merged 2 commits into from
Dec 8, 2021
Merged

refactor: Time::getDst() #5415

merged 2 commits into from
Dec 8, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 30, 2021

Description

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 30, 2021
paulbalandan
paulbalandan reviewed Dec 7, 2021
View reviewed changes
system/I18n/Time.php Outdated Show resolved Hide resolved
@kenjis @paulbalandan
refactor: compare it to the return value to make it easier to underst…
bb82f4e 
…and what it is doing

Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@kenjis kenjis merged commit ec898f7 into codeigniter4:develop Dec 8, 2021
@kenjis kenjis deleted the fix-time-getdst branch December 8, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan