-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CSRF token randomization #5283
Merged
kenjis
merged 7 commits into
codeigniter4:develop
from
kenjis:feat-csrf-token-randomization
Nov 14, 2021
Merged
feat: add CSRF token randomization #5283
kenjis
merged 7 commits into
codeigniter4:develop
from
kenjis:feat-csrf-token-randomization
Nov 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
approved these changes
Nov 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not great with cryptography. This looks good to me but I would like it if someone else reviewed as well.
tests/system/Security/SecurityCSRFSessionRandomizeTokenTest.php
Outdated
Show resolved
Hide resolved
tests/system/Security/SecurityCSRFSessionRandomizeTokenTest.php
Outdated
Show resolved
Hide resolved
To make it easier to identify binary or hex
Because the use case where users want to increase the value is assumed.
I added User Guide. |
MGatner
approved these changes
Nov 14, 2021
paulbalandan
approved these changes
Nov 14, 2021
Thanks, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Config\Security::$tokenRandomize
(default isfalse
)Config\Security::$tokenRandomize
istrue
Checklist: