Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove incorrect processing of CLI params #5274

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Fix: remove incorrect processing of CLI params #5274

merged 1 commit into from
Nov 21, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 2, 2021 •
edited
Loading

Description
Fixes #5266

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title Remove incorrect processing of CLI params Fix: remove incorrect processing of CLI params Nov 2, 2021
paulbalandan
paulbalandan approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this but let's wait for others' comments.

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 9, 2021
@kenjis kenjis merged commit 10496ff into codeigniter4:develop Nov 21, 2021
@kenjis kenjis deleted the fix-cli-params branch November 21, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: CLI command can't get param data properly
3 participants
@kenjis @samsonasik @paulbalandan