Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify logic of number_to_roman function #5270

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Simplify logic of number_to_roman function #5270

merged 1 commit into from
Nov 1, 2021

Conversation

paulbalandan
Copy link
Member

Description
The logic currently is too difficult to digest.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had never seen this code before, what a convolution! Nice cleanup.

@paulbalandan paulbalandan merged commit b8c1939 into codeigniter4:develop Nov 1, 2021
@paulbalandan paulbalandan deleted the number-to-roman branch November 1, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @MGatner