Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust orange color in debug toolbar #5136

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Sep 26, 2021

Change shade of orange, from matt orange (#FDC894) to glossy orange (#DD8615), as the current color doesn't have enough contrast with background. Before and after:
light_before
light_after

I made the same change to dark theme, as I think it's also prettier, and because currently both light and dark themes use the same shades of *-orange at the same places, so better keep this consistency. Before and after:
dark_before
dark_after

I made this PR because on Pale Moon browser these texts are less bold, and see how the current color is barely readable:
pale_moon

@paulbalandan paulbalandan merged commit 09e876c into codeigniter4:develop Sep 26, 2021
@vlakoff vlakoff deleted the debug-toolbar-2 branch October 1, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants