Fix query binding with two colons in query

[kenjis]

Description
Fixes #5114

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[MGatner]

This looks good to me but Database is my "blind spot" so I'd like @paulbalandan or @samsonasik to take a look.

[paulbalandan]

I overlooked a detail in the later part. Sorry for the noise.

[paulbalandan]

Thank you, @kenjis

[vlakoff]

I have checked the differences between the two codes, and I don't see where is the functional difference.

The change in code is that a ! $hasBinds condition has been added when determining $hasNamedBinds,
but nevertheless the early return is triggered when both ! $hasNamedBinds && ! $hasBinds.

So, if $hasBinds is true, there can't be early return, and if $hasBinds is false, $hasNamedBinds gets determined as previously.

[kenjis]

What are the two codes?

$hasBinds means the query contains bindings, that is ?.
$hasNamedBinds means the query contains named bindings, that is something like:name:.
They are exclusive. We cannot use both at a time.
So I added ! $hasBinds condition when determining $hasNamedBinds.

! $hasNamedBinds && ! $hasBinds means the query does not have :name: nor ?.
That is no bindings at all. So we have nothing to process bindings.
So we go early return.

[vlakoff]

I understood, what your change influences is actually a line that is a bit below in the code:

$sql = $hasNamedBinds ? $this->matchNamedBinds($sql, $binds) : $this->matchSimpleBinds($sql, $binds, $bindCount, $ml);

[vlakoff]

Though, the code would fail with named binds, simply if there is a "?" somewhere in the supplied SQL string.

As a quick example:

SELECT * FROM songs WHERE band = :band: AND title = 'Do You Love Me?'

hasBinds would be erroneously true, which in turn would make hasNamedBinds erroneously false.

[vlakoff]

Refs #5138.