Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unintended dead code in pre-commit #5116

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Remove unintended dead code in pre-commit #5116

merged 1 commit into from
Sep 24, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 23, 2021

Description
fixes #5107

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPdocs
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

paulbalandan
paulbalandan approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is practically useless, I think this is the right way to go.

@paulbalandan paulbalandan merged commit 55183fc into codeigniter4:develop Sep 24, 2021
@kenjis kenjis deleted the fix-pre-commit-dead-code branch September 24, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git pre-commit takes no params
2 participants
@kenjis @paulbalandan