Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable variable $$id in RedisHandler #5062

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix variable variable $$id in RedisHandler #5062

merged 1 commit into from
Sep 8, 2021

Conversation

Terrorboy
Copy link
Contributor

@Terrorboy Terrorboy commented Sep 8, 2021 •
edited by paulbalandan
Loading

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
Copy link
Member

@Terrorboy I know what the fix is about, but can you tell us what is the problem you encountered because of this?

@Terrorboy
Copy link
Contributor Author

Terrorboy commented Sep 8, 2021 •
edited
Loading

@paulbalandan

I'm going out, so I'm attaching a screenshot I'm keeping.

1631095242743.png

paulbalandan
paulbalandan approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at git blame, it seems I accidentally used variable variables when making the handlers compatible with SessionHandlerInterface.

@paulbalandan paulbalandan changed the title v4.1.4 redis session error fix Fix variable variable $$id in RedisHandler Sep 8, 2021
@paulbalandan paulbalandan merged commit 6927092 into codeigniter4:develop Sep 8, 2021
@paulbalandan
Copy link
Member

Thank you, @Terrorboy

@Terrorboy
Copy link
Contributor Author

@paulbalandan When does codeigniter4codeigniter4/framework apply?

@paulbalandan
Copy link
Member

Not sure when it can be released. For the meantime you can use the development version, or manually update the fix in your installation while waiting for next release.

@Terrorboy
Copy link
Contributor Author

All right.

@sfadschm sfadschm mentioned this pull request Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Terrorboy @paulbalandan