Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply NoCodeSeparatorCommentFixer #5053

Merged

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

@sfadschm
Copy link
Contributor

sfadschm commented Sep 4, 2021

From the code it is supposed to remove the
//------------------.

@paulbalandan
Copy link
Member Author

Yes, it removes code separator comments, except when used in "sections"

 //---------------------------------
 // A section title
 //---------------------------------

 $foo;
-//---------------------------------
 $bar;

@MGatner MGatner merged commit 1444142 into codeigniter4:develop Sep 5, 2021
@paulbalandan paulbalandan deleted the no-code-separators-fixer branch September 5, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants