Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding foreign keys with only string fields #4988

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

paulbalandan
Copy link
Member

Fixes #4986

@paulbalandan paulbalandan linked an issue Aug 5, 2021 that may be closed by this pull request
@paulbalandan paulbalandan force-pushed the forge-foreign-key branch 4 times, most recently from a968b2f to 1ee903b Compare August 6, 2021 02:54
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tests.

@paulbalandan paulbalandan merged commit 6e4d5e7 into codeigniter4:4.2 Aug 6, 2021
@paulbalandan paulbalandan deleted the forge-foreign-key branch August 6, 2021 13:07
paulbalandan added a commit to paulbalandan/CodeIgniter4 that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot addForeignKey for raw string as field (Forge)
2 participants