New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix properly the phpstan error in 0.12.93 #4970

Merged

samsonasik merged 2 commits into codeigniter4:develop from paulbalandan:phpstan-non-empty-string

Jul 28, 2021

Member

paulbalandan commented Jul 27, 2021

Description

Proper fix for phpstan error in Update rector/rector requirement from 0.11.37 to 0.11.40 #4967 (explode does not accept an empty string delimiter which the code does not take into account)
Add tests for the File::getDestination method where this error arises

Checklist:

Securely signed commits
Unit testing, with >80% coverage
Conforms to style guide

paulbalandan added 2 commits

July 27, 2021 23:18


          Fix phpstan error properly

087c115


          Add tests for File::getDestination

7f6783e

samsonasik approved these changes

View reviewed changes

samsonasik merged commit bb40ac8 into codeigniter4:develop

Member

samsonasik commented Jul 28, 2021

Thank you @paulbalandan

paulbalandan deleted the phpstan-non-empty-string branch

July 28, 2021 10:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet