Remove useless code separator comments #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never thought there are ao many of them ... |
MGatner
approved these changes
Jul 19, 2021
| // @codeCoverageIgnoreStart | ||
| exit($code); | ||
| // @codeCoverageIgnoreEnd | ||
| exit($code); // @codeCoverageIgnore |
There was a problem hiding this comment.
Any chance there is a CS Fixer or Rector rule for converting these start-end for single lines? @samsonasik
There was a problem hiding this comment.
removing before and after comment (before and next different line) is doable with rector, but I am not sure about placing comment on single line directly right after statement. Probably need to extends the pComments() method:
with some kind of custom attribute to flag single line.
element-code
pushed a commit
to element-code/CodeIgniter4
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...unless used as headers (except the header use is 🙄 or 🤷♂️)
Checklist: