[Debug] [4.2] Structure debug toolbar timeline with collapsible elements. #4886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #4865.
This PR intrduces structuring of the debugbar timeline elements.
They are now sorted in a parent-children structure like this:
These elements are then echoed recursively and embedded in JS collapsible table rows.
For now, the
Controller
parent element is unfolded by default, as this will likely alway be the biggest and last part of the timeline.One thing I am not yet fond of is the flexible indentation of the
Timer
name in the current state. That is, each deeper level is indented by an additional 10px, which I think might pose some issue on very narrow screens.Demonstration
Timeline.Demonstration.mp4
Checklist: