-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.1 #4883
Add support for PHP 8.1 #4883
Conversation
5b29225
to
2d4c76c
Compare
Initial incompat we have is the session handlers extending
|
Where are we at on this? It's a couple months old now, and I'd love to get some of these cleaned up and either merged or closed. |
2d4c76c
to
f8559ed
Compare
f8559ed
to
01e6edc
Compare
Glad this is going smoothly! Should make for an easy transition this fall so we can focus on the 7.4 minimum. |
01e6edc
to
853bfc3
Compare
f970bc8
to
ffad503
Compare
31bba00
to
9310036
Compare
05bbd1d
to
73480cf
Compare
8432f92
to
512431f
Compare
bddecda
to
4e07a4b
Compare
4e07a4b
to
732144c
Compare
I'll be splitting unrelated changes in separate PRs. |
732144c
to
488e495
Compare
488e495
to
f729426
Compare
e95c41b
to
eca11c3
Compare
eca11c3
to
d992646
Compare
All green 🎉 I just would have to comment. Tests in PHP 8.1, excluding MySQLi, are pretty fast. Slow tests are now between 20-30 tests. |
That's awesome! I'm excited to see what dropping 7.3 does to our overall Actions runtime. If 8.1 is noticeably faster would should be looking at a sizable improvement. 8.1 should land today! Merge when you're ready. |
Just in time! 8.1 is now stable on |
Description:
PHP 8.1 will be released in a few months and we should ensure the framework is compatible by then.
Detected issues:
FILTER_SANITIZE_STRING
is deprecated Bug: FILTER_SANITIZE_STRING is deprecated (PHP 8.1.0 early test) #4938 (Fixed in Replace deprecated FILTER_SANITIZE_STRING #5005 and Replace usage ofFILTER_SANITIZE_STRING
#5263)predis/predis
related incompatible signatures (Fixed in AddReturnTypeWillChange
attribute to CursorBasedIterator predis/predis#708)mikey179/vfsstream
related incompatible signatures (Fixed in Add annotations to indicate return type will change bovigo/vfsStream#261)ReturnTypeWillChange
attribute to Entity #5028)null
to parameters historically allowing to pass null but now explicitly disallowing so. (Fixed in Fix deprecated usage ofnull
onstring
params of internal functions #5371, Additional fix for deprecatednull
usage #5388)PgSql\Result
(Fixed in Fix compatibility of Postgres result for PHP 8.1 #5278, Fix compatibility ofPgSql\Result
on closing the result instance #5279)Checklist: