Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Query.php #4764

Closed
wants to merge 1 commit into from
Closed

Conversation

randallmoraes
Copy link

@randallmoraes randallmoraes commented Jun 1, 2021

With the regular expression '/:[a-z\d.)_()+:/i' the criteria are not met when there is a function in the where, for example :

MD5 (field) = $ value
MD5 (concat(field1,field2)) = $ value

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

With the regular expression '/:[a-z\d.)_()+:/i' the criteria are not met when there is a function in the where, for example :
MD5 (field) = $ value
MD5 (concat(field1,field2)) = $ value
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just reverted this to the old condition which does not work with postgres JSON operators. I would be keen to accept this for a more inclusive regex.

And please add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants