Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format URI directly #4715

Merged
merged 1 commit into from
May 25, 2021
Merged

Format URI directly #4715

merged 1 commit into from
May 25, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented May 21, 2021

Description
Fixes #4707, where CURLRequest's baseURI could get muddled with App::$baseUrl during URI::__toString().

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@MGatner MGatner mentioned this pull request May 21, 2021
Merged
4 tasks
@MGatner MGatner requested a review from paulbalandan May 25, 2021 15:24
@MGatner MGatner merged commit 0eff770 into codeigniter4:develop May 25, 2021
@MGatner MGatner deleted the curl-base branch May 25, 2021 15:46
@MGatner MGatner mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: curlrequest not using baseURI on localhost
2 participants
@MGatner @paulbalandan