Internal URI handling #4646
Merged
Internal URI handling #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rerunning now that stage one is merged. @lonnieezell did you get a chance to look at this one yet? Has implications for the |
|
Yeah, I didn't have any problems with this one. Good to go as far as I'm concerned. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Stage two" of URI changes, this PR backs off some of the heavy-handed coercing that
URI::__toString()does to create "project URLs". IMOURIshould not be in the business of dealing withbaseURLat all, but since this is currently the case we can't remove it entirely. Also improvesIncomingRequest's interactions withURIto detect the "current" URL, and fixes a bug where scheme inconsistencies could create looping redirects.Note: This PR relies on #4644
Checklist: