Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache getMetadata() Format #4629

Merged
merged 2 commits into from
May 1, 2021
Merged

Cache getMetadata() Format #4629

merged 2 commits into from
May 1, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Apr 30, 2021 •
edited
Loading

Description
CacheInterface::getMetadata() thus far returns a generic array of info "dependent on each adapter", as well as false or null for missing items (also dependent on each adapter). This PR attempts to standardize the expected return values while still leaving the false in place for now. Additionally:

  • Fixes a bug where "expire" was not always an absolute time value
  • Fixes a discrepancy between relative and absolute TTL values
  • Adds support for null values to "expire" when a TTL was specified as "never expire"

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner changed the title Standardize getMetadata Cache getMetadata() Format Apr 30, 2021
@MGatner MGatner requested a review from paulbalandan May 1, 2021 14:58
@MGatner MGatner merged commit 0118201 into codeigniter4:develop May 1, 2021
@MGatner MGatner deleted the cache-expires branch May 1, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @paulbalandan