Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-persistent fake #4607

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Conversation

dcaswel
Copy link
Contributor

@dcaswel dcaswel commented Apr 24, 2021

Description
Added a parameter to the fake() test helper so that you can use it without saving the object in the database.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@dcaswel
Copy link
Contributor Author

dcaswel commented Apr 24, 2021

Some help would be appreciated as the failure I am getting shouldn't have anything to do with my code and I pulled the latest develop like an hour before submitting this PR.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot, great addition! I don't see the failure you are referring to, it shows all checks passed to me. Maybe you fixed it already?

@paulbalandan
Copy link
Member

I like this a lot, great addition! I don't see the failure you are referring to, it shows all checks passed to me. Maybe you fixed it already?

Oh, I've re-run the tests. Failing was the PredisHandlerTest on metadata again.

@paulbalandan paulbalandan merged commit 0879a35 into codeigniter4:develop Apr 24, 2021
@dcaswel
Copy link
Contributor Author

dcaswel commented Apr 24, 2021

@paulbalandan Thanks for rerunning those tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants