-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation of array data #4606
Fix validation of array data #4606
Conversation
1426e59
to
67d30da
Compare
Thank you very much Paul! I tested the changes and now it works fine, only one detail @WinterSilence detect another use case when an empty array is sent, it evaluates it as true, what do you think about it? |
67d30da
to
44957ad
Compare
My latest push contains some fix for empty arrays. Can you check also? |
Perfect I was solved! thank you very much for your time paul! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my one comment, everything else looks great.
Description
Fixes #4510
This changes the behavior of
_array_search_dot
. Currently, the function returns early when it matched a non-null element in its value traversal, leaving the remaining elements in the loop as untouched. This PR accumulates the finds in an array, filters out the nulls. If resulting array contains only one element, then we'll return that element instead of an array in order to preserve BC. Otherwise, an array containing matches will be returned.@luispastendev, can you check this? This passes locally on your use case .
Checklist: