[Rector] Apply Full PHP 7.3 Rector Set List #4600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
samsonasik
force-pushed
the
apply-rector-php73-feature
branch
from
2b2182c to
dc8f30a
Compare
| @@ -45,6 +45,8 @@ parameters: | |||
| - '#Return type \(bool\) of method CodeIgniter\\Log\\Logger::(emergency|alert|critical|error|warning|notice|info|debug|log)\(\) should be compatible with return type \(null\) of method Psr\\Log\\LoggerInterface::(emergency|alert|critical|error|warning|notice|info|debug|log)\(\)#' | |||
| - '#Return type \(bool\) of method CodeIgniter\\HTTP\\Files\\UploadedFile::move\(\) should be compatible with return type \(CodeIgniter\\Files\\File\) of method CodeIgniter\\Files\\File::move\(\)#' | |||
| - '#Return type \(bool\) of method CodeIgniter\\Test\\TestLogger::log\(\) should be compatible with return type \(null\) of method Psr\\Log\\LoggerInterface::log\(\)#' | |||
| - '#Parameter \#2 \$assoc of function json_decode expects bool, null given#' | |||
| reportUnmatchedIgnoredErrors: false | |||
There was a problem hiding this comment.
I think this should be set as true so that we can remove errors no longer applicable.
There was a problem hiding this comment.
yes, it currently shows notice in php < 8
|
I can create another alternative PR for allow |
|
Generally I agree about throwing new errors but looking through these specific instances I think a failed operation will already cause other errors that will just be harder to track down. The exception may be the Toolbar changes but that's only for dev instances anyways when (I believe) we want to be throwing more errors anyway. |
|
Closing in favor of #4601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using :
to apply full php 7.3 rector set list.
Checklist: