Simplify Cookie Class

[mostafakhudair]

Since we use php min version 7.3, why not passing all cookie options to the constructor itself directly.
Removed Cookie::create while new Cookie do the same thing directly.
Renamed Cookie::getExpiresTimestamp to Cookie::getExpires to be short and refer to it's property,
Renamed Cookie::withExpiresAt to Cookie::withExpires to fit it's property and also it may return expired cookie.

I think this is last change to new Cookie class should be done before the upcoming release

@paulbalandan what do you think about this changes? is it keeps the interface "fluent"? Thanks in advance

[paulbalandan]

Your PR title is for changing the Cookie constructor yet you clearly have two PRs here.

1. I approve the simplification of the constructor call for the Cookie as that is leaning towards 7.3.
2. Unless you can give me reason why convertExpiresTimestamp is no longer accessible via class, I cannot accept the removal of static.
3. For the expires changes (which clearly misplaced here in this PR), I understand that you want to make things simple here but I'm on the side of making things "fluent" on the side of the developer using this API. For example, if I want to make an "expired" Cookie object, which would I choose as more fluent -- $cookie->withExpires(0) or $cookie->withExpired(). I believe even non-devs would choose the 2nd option as that is clearer. Another one is I want to get the expires string suitable for Set-Cookie headers. I would definitely want to use $cookie->getExpiresString() over $cookie->getExpires(false). The getExpiresTimestamp() on the other hand is a side effect of having getExpiresString() so as to differentiate the two expires getters. It will be clear that one gets the string expires while the other gets the integer value.
4. I don't get why the tests on Array Access were removed when there's no changes to that in the class. By removing those tests I'm assuming that the Cookie, after this PR change, now allows mutability which is in contrast to its immutable nature.

[mostafakhudair]

Cookie::getExpiresString is still here and has not been removed.

[MGatner]

I assume this is yet another PR that will need to be resolved before release. Please prioritize this.

[paulbalandan]

Unless you'll revert all changes to expires we can get this merged. Otherwise, I'm afraid that is a blocker for merge.

On a side note, I think I made a mistake with withExpiresAt($expires = 0) by setting a default value. This should not be the case. It should be only withExpiresAt($expires).

[paulbalandan]

Thank you, @mostafakhudair

[mostafakhudair]

@paulbalandan Many thanks to you for you'r professional review and your patience

[MGatner]

Thanks all around! I think we are now finally cleared for release.