Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rector] Remove RemoveDefaultArgumentValueRector #4576

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 15, 2021

After some checks, it is complicated to be copied as it will need more configure services injection to set when next rector released with the services required removed.

I think we can remove it instead.

Checklist:

  • Securely signed commits

@samsonasik samsonasik merged commit d936d5e into codeigniter4:develop Apr 16, 2021
@samsonasik samsonasik deleted the remove-remove-default-argument-value-2 branch April 16, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant