Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for masking sensitive debug data #4550

Merged
merged 10 commits into from
Apr 16, 2021
Merged

Support for masking sensitive debug data #4550

merged 10 commits into from
Apr 16, 2021

Conversation

pixobit
Copy link
Contributor

@pixobit pixobit commented Apr 10, 2021

Description
Sometimes we want to hide sensitive information from the debug trace, even if it's only for the development environment.
This makes it possible.
To give more context to this matter, here's a link that addresses a similar issue on laravel: laravel/ideas#1236

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Isti369 added 2 commits April 10, 2021 22:33
Sometimes we want to hide sensitive information from the debug trace, even if it's only for the development environment. This makes it possible.
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the coding style and make sure code is compatible with 7.3+. You're using str_ends_with of php8

@pixobit pixobit requested a review from paulbalandan April 11, 2021 09:24
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show a sample output using this ?

system/Debug/Exceptions.php Outdated Show resolved Hide resolved
system/Debug/Exceptions.php Outdated Show resolved Hide resolved
system/Debug/Exceptions.php Outdated Show resolved Hide resolved
system/Debug/Exceptions.php Outdated Show resolved Hide resolved
@pixobit pixobit requested a review from paulbalandan April 12, 2021 03:03
@paulbalandan paulbalandan merged commit 111f740 into codeigniter4:develop Apr 16, 2021
@kenjis kenjis added enhancement PRs that improve existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. GPG-Signing needed Pull requests that need GPG-Signing labels Jul 14, 2023
* --------------------------------------------------------------------------
* Any data that you would like to hide from the debug trace.
* In order to specify 2 levels, use "/" to separate.
* ex. ['server', 'setup/password', 'secret_token']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 'server' in the example? What is level ?
What does this feature hide?
Does this feature really work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs needed Pull requests needing documentation write-ups and/or revisions. enhancement PRs that improve existing functionalities GPG-Signing needed Pull requests that need GPG-Signing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants