Create Config::Cookie Class

[mostafakhudair]

While we are taking a step forward to make config folder separated as much as possible, Cookie class should have it's own config file

[MGatner]

This is a good change. I would like to make a release this weekend, which would solidify all the Cookie changes since 4.1 - let's be sure to get this finished so it can be included.

[mostafakhudair]

@MGatner I think next release should be done without any of new Cookie Class, because of cookie class is bloated with alot usless methods and need to be refactored, also to avoid BC

[MGatner]

@mostafakhudair I thought there had been significant improvements to our Cookie handling since the last release, work that you and @paulbalandan both did. What do you think should be held back? Is it something that can easily be reverted and re-applied for the following release?

Paul, what are your thoughts?

[paulbalandan]

Bloated? What aspects of the Cookie are bloated? Cookie is just implementing its contract interfaces' methods, which are actually getters and cloners of a web cookie's attributes. Plus, it has bonus methods to help parse a Cookie-Header string into a functional Cookie object, and some validation methods to make sure the passed attributes are valid against the multitude of cookie specifications. Are these useless to you? The bloat, I would say IMO, is the ArrayAccess implementation and some ?: logic, but that is a compromise to retain backward compatibility to the time cookie handling was just using plain arrays.

If you can pinpoint the places that needs refactor, we'd consider excluding cookie in the release and perhaps I'd do the refactor myself. Otherwise, aside from the config reassignment, the cookie class is stable as-is.

[samsonasik]

@mostafakhudair please incorporate @paulbalandan review

[mostafakhudair]

What is wrong with tests?

[samsonasik]

That seems race condition issue in SQLSRV action. It seems unrelated.

[MGatner]

Have tests been rerun since #4539?

[mostafakhudair]

Yes, twice

[paulbalandan]

Thank you, @mostafakhudair

[MGatner]

🥳