[Rector] Update rector to ^0.10

[samsonasik]

Checklist:

• Securely signed commits

[samsonasik]

Hi @TomasVotruba , I tried to update rector/rector to ^0.10, and in this case, I got the following notice:

vendor/bin/rector process system/CLI/BaseCommand.php --dry-run

Could not process "system/CLI/BaseCommand.php" file, due to:                                                   
         "Analyze error: "Error (Call to undefined function CodeIgniter\CLI\is_cli()) thrown while looking for class    
         CodeIgniter\CLI\CLI.". Include your files in "$parameters->set(Option::AUTOLOAD_PATHS, [...]);" in "rector.php"
         config.                                                                                                        
         See https://github.com/rectorphp/rector#configuration".  

The is_cli() function is on system/Common.php. Looking at autoload paths, it should already included as __DIR__ . '/system/Test/bootstrap.php' include it:

	// Rector relies on autoload setup of your project; Composer autoload is included by default; to add more:
	$parameters->set(Option::AUTOLOAD_PATHS, [
		// autoload specific file
		__DIR__ . '/system/Test/bootstrap.php',
	]);

even if I tried manually add system/Common.php:

	// Rector relies on autoload setup of your project; Composer autoload is included by default; to add more:
	$parameters->set(Option::AUTOLOAD_PATHS, [
		// autoload specific file
		__DIR__ . '/system/Test/bootstrap.php',
		__DIR__ . '/system/Common.php',
	]);

it still got above notice, any idea to resolve it? Thank you.

[MGatner]

Looks like some work yet to be done here, but I would be glad to see us on the latest.

[TomasVotruba]

I'm looking into this. I tried to isolate the code but there is too many other packages.

It seems it fails on this minimal code:

use CodeIgniter\CLI\CLI;

class SomeClass
{
	public function showHelp()
	{
		CLI::write('...');
	}
}

class CLI
{
	public static function init()
    {
       return is_cli();
    }
}

// this is called for some reason
CLI::init();

Could you create minimal reproducible repository?

[samsonasik]

I will try

[samsonasik]

@TomasVotruba I created a minimal repo that show that the autoload file with code die; is skipped there:

https://github.com/samsonasik/rector-issue-010-autoload

Somehow, the system/Test/bootstrap.php is not loaded/ignored, as I tried add :

die('stop here');

in top of system/Test/bootstrap.php, and it not stopped:

In rector 0.9, it will print : "stop here", while in rector 0.10, it just skipped.

[samsonasik]

@TomasVotruba I created rector issue for it rectorphp/rector#5951

[samsonasik]

@TomasVotruba I found temporary solution by add :

require_once __DIR__ . '/system/Test/bootstrap.php';

outside rector config 1eb86d8 to ensure require_once loaded.

[samsonasik]

All green 🎉

[TomasVotruba]

@samsonasik This should help rectorphp/rector#5964

[samsonasik]

@TomasVotruba thank you 👍