Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Parser file path in ViewException message is empty #4191

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Fix Parser file path in ViewException message is empty #4191

merged 3 commits into from
Jan 30, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 30, 2021

Description

  • add invalid file path in ViewException message, so that we can see the invalid view name.
  • fix indentation

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan merged commit 457e71d into codeigniter4:develop Jan 30, 2021
@kenjis kenjis deleted the fix-Parser-render branch October 9, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan