Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache File mode #4103

Merged
merged 5 commits into from
Jan 16, 2021
Merged

Add Cache File mode #4103

merged 5 commits into from
Jan 16, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jan 14, 2021

Description

  • Adds support for configurable file modes when using the FileHandler for caching.
  • Deprecates Config\Cache::$storePath in favor of a new driver-specific array of settings (similar to other drivers)
  • Fixes a bug where '0' was not allowed as a cache prefix

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member Author

MGatner commented Jan 14, 2021

Failure is unrelated.

@MGatner MGatner requested a review from michalsn January 14, 2021 19:56
@MGatner
Copy link
Member Author

MGatner commented Jan 15, 2021

While moving things around I noticed that we use $this->prefix = $config->prefix ?: '' in all the handlers. Since Config\Cache::$prefix is already defined as a string all this essentially does is disables using falsey '0' as a prefix, so I've changed it out (still cast as a string in case someone has it incorrectly typed).

@MGatner MGatner requested a review from paulbalandan January 15, 2021 14:32
@MGatner MGatner merged commit 2a0d39f into codeigniter4:develop Jan 16, 2021
@MGatner MGatner deleted the cache-permissions branch January 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants