Model/BaseModel - Fix primary key and add @throws for builder method #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en split was done
michalsn
reviewed
Jan 6, 2021
najdanovicivan
force-pushed
the
nosql/base-model-fix
branch
from
83c1a86 to
b01cb98
Compare
najdanovicivan
changed the title
I was looking at the code from master branch. But the builder() method was made public before I did the BaseModel split so it should be left as public |
michalsn
approved these changes
Jan 7, 2021
paulbalandan
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue with primaryKey property which was unintentionally left inside base model. This also ads @throws for builder() method
Checklist: