Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full table name with schema for SQLSRV #4058

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Use full table name with schema for SQLSRV #4058

merged 1 commit into from
Jan 5, 2021

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jan 3, 2021

Description
This PR changes the behavior of the Builder class for SQLSRV to always use the full table name - with a schema.

Ref #3881

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have particular knowledge of this but the code looks good!

@MGatner MGatner merged commit 5ad1235 into codeigniter4:develop Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalsn @MGatner @paulbalandan