Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added omitted function parameter description. #4052

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Added omitted function parameter description. #4052

merged 2 commits into from
Jan 2, 2021

Conversation

francis94c
Copy link
Contributor

While using the delete_files helper function, i noticed that a parameter was not documented. This pull request takes care of that.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • [x ] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Jan 2, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the function's signature. The $hidden param is not included. Also, please change $del_dir to $delDir

@francis94c
Copy link
Contributor Author

Alright.

@francis94c
Copy link
Contributor Author

Done

@paulbalandan paulbalandan merged commit 2209683 into codeigniter4:develop Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francis94c @paulbalandan