Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix countAll() docs #4050

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Fix countAll() docs #4050

merged 2 commits into from
Jan 2, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 1, 2021

Description
Fix countAll() documentation.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This has caused some confusion recently on the forums.

@MGatner MGatner merged commit 4ea15f8 into codeigniter4:develop Jan 2, 2021
@kenjis kenjis deleted the fix-countAll branch January 2, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner