initial signed commit of code changes to add ResultInterface::getNumRows #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abase/ResultInterface and the various DBMS-specific Result classes. Added unit tests/system/Database/Live/GetNumRowsTest.php for this newly added method. Added an entry in the user docs for getNumRows method.
|
Once again, I've made some mistakes. Closing this request, too. Will run phpstan and see if i get better results. |
|
@sneakyimp You didn't make any mistakes. This PR is better than previous one. |
|
@kenjis it's failing all the tests. I want it to be clean. I also left out the user documentation change. I've got one more I think will do it. Will submit momentarily. |
|
I have addressed that and have submitted a new PR (see #4049 ). Rector doesn't like it (the SQLite3 implementation does not support the function and just throws an exception) but I think it's worth a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also to the various DBMS-specific Result classes. Added unit tests/system/Database/Live/GetNumRowsTest.php for this newly added method. Added an entry in the user docs for getNumRows method.
Description
Per Lonnie Ezell's message in #109, I have attempted my first CodeIgniter fork/branch/pull request here. It adds a getNumRows method to the ResultInterface and the various DBMS classes that extend it. This pull request supercedes a previous messy one (for which I apologize).
Checklist: