Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line for License copyright #4029

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Dec 26, 2020

Description
I didn't render before, and the result is like below: (https://codeigniter4.github.io/CodeIgniter4/license.html)
image

And now, the expected is:
image

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@@ -2,8 +2,8 @@
The MIT License (MIT)
#####################

Copyright (c) 2014-2019 British Columbia Institute of Technology
Copyright (c) 2019-2020 CodeIgniter Foundation
| Copyright (c) 2014-2019 British Columbia Institute of Technology
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a space at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, my mistake

@MGatner MGatner merged commit 4d5bbdf into codeigniter4:develop Dec 27, 2020
@totoprayogo1916 totoprayogo1916 deleted the userguide branch December 28, 2020 03:44
mostafakhudair added a commit to mostafakhudair/CodeIgniter4 that referenced this pull request Dec 28, 2020
mostafakhudair added a commit to mostafakhudair/CodeIgniter4 that referenced this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants