Rename Sqlsrv driver #4023
Merged
Rename Sqlsrv driver #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Since there was no official release that would include Sqlsrv, I'm okay with this change.
I just want to point out that our naming convention doesn't follow the naming convention used in PHP database extensions. Because of this, any other attempts of unification shouldn't happen before v5 (because of BC).
MGatner
approved these changes
Dec 25, 2020
paulbalandan
approved these changes
Dec 26, 2020
samsonasik
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
Sqlsrvdriver toSQLSRVto compatible with PHP extension name, like other drivers MySQLi, SQLite3 etc...