Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make form_hidden based on form_input #4001

Merged
merged 1 commit into from
Dec 19, 2020
Merged

make form_hidden based on form_input #4001

merged 1 commit into from
Dec 19, 2020
+7 −7

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Dec 19, 2020 •
edited
Loading

Description
As far as I know, hidden fields do not require additional styles.
And with this, make form_input the basis for creating form_hidden.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@totoprayogo1916 totoprayogo1916 marked this pull request as draft December 19, 2020 04:10
@totoprayogo1916 totoprayogo1916 marked this pull request as ready for review December 19, 2020 05:37
@samsonasik samsonasik merged commit f15c92e into codeigniter4:develop Dec 19, 2020
@samsonasik
Copy link
Member

Thank you @totoprayogo1916

@totoprayogo1916 totoprayogo1916 deleted the fix/form-helper branch December 19, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totoprayogo1916 @samsonasik