Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up language folder. #3950

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Clean up language folder. #3950

merged 6 commits into from
Dec 2, 2020

Conversation

sfadschm
Copy link
Contributor

@sfadschm sfadschm commented Dec 1, 2020

This PR tries to clean up the Language folder a little bit.
Also completes tests for the language class.

I tried searching every defined language key thoughout the whole framework and already removed the one that I was sure about:

Here is some other keys that do not seem to be used, but maybe still should stay:

  • Database.php

    • Database.parseStringFail
    • Database.featureUnavailable
  • Email.php

    • Email.sendFailurePHPMail
    • Email.sendFailureSendmail
    • Email.sendFailureSmtp
  • Images.php

    • Images.gdRequired
    • Images.gdRequiredForProps
    • Images.jpgOrPngRequired
    • Images.rotateUnsupported
    • Images.copyFailed
    • Images.missingFont
  • Migrations.php

    • Migrations.missingTable
    • Migrations.empty
    • Migrations.migHelpLatest
    • Migrations.migHelpCurrent
    • Migrations.migHelpVersion
    • Migrations.migHelpRollback
    • Migrations.migHelpRefresh
    • Migrations.migHelpSeed
    • Migrations.migCreate
    • Migrations.migNumberError
    • Migrations.migInvalidVersion
    • Migrations.toVersionPH
    • Migrations.toVersion
    • Migrations.migMissingSeeder

Opinions on the listed keys are appreciated.

Checklist:

  • Securely signed commits

@paulbalandan
Copy link
Member

For the first three strings I'm in for removing those but for the latter let's prolong their stay there as they can be used in user's code. For the first three I'm sure they aren't used anymore since they were removed before the stable release or was used only in testing.

@paulbalandan paulbalandan merged commit df249f1 into codeigniter4:develop Dec 2, 2020
@sfadschm sfadschm deleted the clean-up-language branch December 2, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants